Add NetVLAD layer to TF add-ons. #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it passed: pylint --rcfile=/tmp/pylintrc ~/PycharmProjects/addons/tensorflow_addons/layers/netvlad_test.py
This reverts commit 152d694
|
seanpmorgan and facaiy, this is ready for review now |
seanpmorgan
requested changes
Mar 9, 2020
|
@seanpmorgan I finished all your suggestions but one, which I think I addressed in spirit but not exactly what you asked for. Please check that it's sufficient |
seanpmorgan
requested changes
Mar 9, 2020
|
@seanpmorgan done and ready. thanks! |
seanpmorgan
approved these changes
Mar 9, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Add NetVLAD layer to TF add-ons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a layer. Layer description is in the Python class description.