Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add listening_addr to expose fun #1110

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

aseaday
Copy link
Member

@aseaday aseaday commented Oct 28, 2022

#923
It will support the following features;

def build():
    base(os="ubuntu20.04", language="python3")
    runtime.expose(envd_port=4400, listen_addr="172.22.90.240")

The container will listen on

784d93897bf6   envd-quick-start:dev    "horust"      56 seconds ago   Up 54 seconds   127.0.0.1:42277->2222/tcp, 172.22.90.240:40767->4400/tcp   envd-quick-start

PS:

Signed-off-by: nullday <aseaday@hotmail.com>
@muniu-bot
Copy link

muniu-bot bot commented Oct 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aseaday

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the approved label Oct 28, 2022
Signed-off-by: nullday <aseaday@hotmail.com>
@aseaday aseaday changed the title WIP feat: Add listening_addr to expose fun feat: Add listening_addr to expose fun Oct 28, 2022
@gaocegege
Copy link
Member

LGTM

/assign @VoVAllen @kemingy

@gaocegege gaocegege merged commit dedd731 into tensorchord:main Oct 29, 2022
@gaocegege
Copy link
Member

@aseaday We should also update the doc, I think.

You can update the comments in https://github.com/tensorchord/envd/tree/main/envd/api

Then the API reference doc will be updated automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants