Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Zaki/max height #238

Merged
merged 3 commits into from
Apr 21, 2019
Merged

Zaki/max height #238

merged 3 commits into from
Apr 21, 2019

Conversation

zmanian
Copy link
Contributor

@zmanian zmanian commented Apr 21, 2019

Introduce a max_height configuration option to stop signing on a chain at certain height.

@zmanian zmanian requested review from liamsi and tarcieri April 21, 2019 15:17
src/config/validator.rs Outdated Show resolved Hide resolved
Make the configuration of type block::Height.

Make the height method on SignableMessage idiomatic
Copy link
Contributor

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tarcieri tarcieri merged commit 5fe1117 into master Apr 21, 2019
@tarcieri tarcieri deleted the zaki/max_height branch April 21, 2019 16:31
@tarcieri tarcieri mentioned this pull request Apr 21, 2019
@tarcieri tarcieri mentioned this pull request Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants