This repository was archived by the owner on Jul 15, 2018. It is now read-only.
Develop pre wire #73
Merged
Develop pre wire #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #43 Avoid susceptibility to timing/side channel attacks by ensuring that private key and signature comparisons use `subtle.ConstantTimeCompare` instead of `bytes.Equal`
Fixes #48. This previously skewed up my fuzzing tests so ensure that on error we return the zero value PubKey.
…pty-pubKey PubKeyFromBytes: return zero value PubKey on error
Constant time equals
The previous doc seemed misleading and was out of date i.e. RandHex(24) not CRandHex. Anyways provide a doc of what the function does in relation to the length of digits of the hex value returned i.e. floor(numDigits / 2) * 2 so the even lowest number e.g: * len(CRandHex(5)) = 4 * len(CRandHex(4)) = 4
CRandHex: fix up doc to mention length of digits
Sdk2 cleanup
Same as 788cc0a but without the new go-wire
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest state of develop before the go-wire upgrade.
It's to enable the SDK client to use the latest
keyswithout needing the latest go-wire.Will need to be merged back in to latest develop