This repository was archived by the owner on Jul 15, 2018. It is now read-only.
Develop #46
Merged
Develop #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #35 Updates tendermint/coding#27 Started a doc.go file to provide an overview/high level dive into the functionality of this repo. Also added an example_test.go file in which we can put end-to-end code examples/actual usage patterns that can be copied and pasted and will always have to compile when tests are run to ensure that we don't regress.
This commit adds salts to the library using bcrypt.
add metalinter to Makefile & apply some fixes
Nano Support
Bcrypt usability
Bugfix: ledger nano/hid compiles on osx/golang1.9
adrianbrink
reviewed
Oct 27, 2017
| if pass == "" { | ||
| return key.Bytes(), nil | ||
| func (e secretbox) Encrypt(privKey crypto.PrivKey, passphrase string) (saltBytes []byte, encBytes []byte, err error) { | ||
| if passphrase == "" { |
There was a problem hiding this comment.
Can't this be deleted, since we don't want users to encrypt keys without a passphrase?
There was a problem hiding this comment.
We break enough stuff with our encryption library. This is the only way to save keys between versions... export unencrypted and import unencrypted.
We should expose them and use them to migrate keys. Until production release and a stable go-crypto
There was a problem hiding this comment.
Does this mean its currently possible to migrate keys? We should defntly be trying to support that asap if possible ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.