Repository navigation
[bugfix] Fix resource table corruption when resources.arsc changes - #65
Draft
HITlittlefox wants to merge 1 commit into
Draft
HITlittlefox wants to merge 1 commit into
HITlittlefox wants to merge 1 commit into
Conversation
…anges Incremental resource.ap_ generation patched resources.arsc as single entries, but arsc is the whole resource table: a partial overlay left the generated apk inconsistent with the full resource set. Fall back to a full rebuild when the change set contains resources.arsc. Also add the task plan doc with unit test evidence for this fix.
HITlittlefox
marked this pull request as draft
October 11, 2026 14:35
Collaborator
|
这个隐患目前未证实存在,原因:
PR 看起来是隐患预防,非实际遇到的问题;如果有明确的可复现步骤/日志,可以提供我看看 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a deploy-state consistency hazard in Jugg incremental deploy:
ResourceApkGeneratorpatchedresources.arscincrementally as single entries, but arsc is the whole resource table; a partial overlay left the generated resource apk inconsistent with the full resource set, risking the same class of resource-state corruption seen as unrelated pages crashing after hot deploy. Change sets containingresources.arscnow fall back to a full rebuild.Linked issue
N/A
Task plan
Task plan
Type
[bugfix]existing behavior is wrongVerification
ResourceApkGeneratorTest#testResourceApkFallsBackToFullRebuildWhenResourceTableChanged: after a baseline exists, a change set containingresources.arscmust rebuild fully instead of patching entries. Class result: 2/2 pass.Documentation
Checklist
build/outputs, or unrelated formatting[prefix][module] subject