fix(clb): [124458743] tencentcloud_clb_instance update create function logic

.changelog/3391.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_clb_instance: update create function logic
+```

tencentcloud/services/clb/resource_tc_clb_instance.go

@@ -428,20 +428,17 @@ func resourceTencentCloudClbInstanceCreate(d *schema.ResourceData, meta interfac
 		}
 	}
 
-	clbId := ""
 	var response *clb.CreateLoadBalancerResponse
 	err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
 		result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseClbClient().CreateLoadBalancer(request)
 		if e != nil {
 			return tccommon.RetryError(e)
 		} else {
-			log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n",
-				logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
-			requestId := *result.Response.RequestId
-			retryErr := waitForTaskFinish(requestId, meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseClbClient())
-			if retryErr != nil {
-				return tccommon.RetryError(errors.WithStack(retryErr))
-			}
+			log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
+		}
+
+		if result == nil || result.Response == nil || result.Response.RequestId == nil {
+			return resource.NonRetryableError(fmt.Errorf("Create CLB instance failed, Response is nil."))
 		}
 
 		response = result
@@ -453,12 +450,18 @@ func resourceTencentCloudClbInstanceCreate(d *schema.ResourceData, meta interfac
 		return err
 	}
 
-	if len(response.Response.LoadBalancerIds) < 1 {
+	// wait
+	requestId := *response.Response.RequestId
+	clbId, err := waitForTaskFinishGetID(requestId, meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseClbClient())
+	if err != nil {
+		return err
+	}
+
+	if clbId == "" {
 		return fmt.Errorf("[CHECK][CLB instance][Create] check: response error, load balancer id is nil")
 	}
 
-	d.SetId(*response.Response.LoadBalancerIds[0])
-	clbId = *response.Response.LoadBalancerIds[0]
+	d.SetId(clbId)
 
 	if v, ok := d.GetOk("security_groups"); ok {
 		sgRequest := clb.NewSetLoadBalancerSecurityGroupsRequest()

tencentcloud/services/clb/service_tencentcloud_clb.go

@@ -1156,6 +1156,35 @@ func waitForTaskFinish(requestId string, meta *clb.Client) (err error) {
 	return
 }
 
+func waitForTaskFinishGetID(requestId string, meta *clb.Client) (clbID string, err error) {
+	request := clb.NewDescribeTaskStatusRequest()
+	request.TaskId = &requestId
+	err = resource.Retry(5*tccommon.ReadRetryTimeout, func() *resource.RetryError {
+		result, e := meta.DescribeTaskStatus(request)
+		if e != nil {
+			return resource.NonRetryableError(errors.WithStack(e))
+		}
+
+		if result == nil || result.Response == nil {
+			return resource.NonRetryableError(fmt.Errorf("Describe task status failed, Response is nil."))
+		}
+
+		if *result.Response.Status == int64(CLB_TASK_EXPANDING) {
+			return resource.RetryableError(errors.WithStack(fmt.Errorf("CLB task status is %d(expanding), requestId is %s", *result.Response.Status, *result.Response.RequestId)))
+		} else if *result.Response.Status == int64(CLB_TASK_FAIL) {
+			return resource.NonRetryableError(errors.WithStack(fmt.Errorf("CLB task status is %d(failed), requestId is %s", *result.Response.Status, *result.Response.RequestId)))
+		}
+
+		if *result.Response.Status == CLB_TASK_SUCCESS && len(result.Response.LoadBalancerIds) == 1 {
+			clbID = *result.Response.LoadBalancerIds[0]
+		}
+
+		return nil
+	})
+
+	return
+}
+
 func flattenBackendList(list []*clb.Backend) (mapping []map[string]interface{}) {
 	result := make([]map[string]interface{}, 0, len(list))
 	for i := range list {