Improved documentation with Spatie\Permissions#100
Improved documentation with Spatie\Permissions#100juhasev wants to merge 1 commit intotenancy:masterfrom
Conversation
juhasev
left a comment
There was a problem hiding this comment.
Load order should read 'CacheServiceProvider' as opposed to 'AppServiceProvider'
|
Also if user is using Redis as session store, the new CacheServiceProvider must be loaded before SessionServiceProvider. |
|
The current example returns null from CLI as the config file driver.php doesn't even exist. Perhaps better alternative would be to set the $uuid variable simply to 'cli'. |
|
Ended up going with Redis based caching for the domains. Join query is sort of expensive. |
|
Feel like this should be moved to the docs regarding laravel-permissions 🤔 |
ArlonAntonius
left a comment
There was a problem hiding this comment.
Other than the one comment, perfect PR. Like I said in a comment, feel like this should be moved to the spatie/permissions tutorial we have, you could add a footnote/sidenote in the cache docs to refer to that specific section in the tutorial.
| > Make sure the CacheServiceProvider is registered in `config/app.php` or else your driver will | ||
| not be available for use. | ||
|
|
||
| If you are using Spatie\Permission package and receive error about driver `redis_tenancy` is not supported, |
There was a problem hiding this comment.
spatie/laravel-permission please :)
No description provided.