feat(chainspec): wrap upstream tempo chainspec#653
Conversation
0xrusowsky
left a comment
There was a problem hiding this comment.
looks good directionally, but left a suggestion and a question
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff, but this repository configures Ask another reviewer to |
|
Hi @adityapk00 — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. Timing note: GitHub delivered this webhook 6.1 seconds after the review approval was created. Try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff but no live Voight-Kampff agent connection received it, so Voight-Kampff sent a push fallback. The push was not approved before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. Timing note: GitHub delivered this webhook 6.4 seconds after the review approval was created. Try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff, but another unexpired approval request is already waiting for your account. Your review did not trigger an approval prompt and is not counted toward this PR. Wait for the current prompt to be approved, rejected, or expire, then re-submit the review to send a fresh approval request. |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
|
Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
This PR updates
ZoneChainSpecto wrap the upstream Tempo chainspec, making it aware of both the Tempo and Zone hardfork schedules.Ref #626