Skip to content

feat(chainspec): wrap upstream tempo chainspec#653

Merged
0xKitsune merged 13 commits into
mainfrom
kit/tempo-chainspec-wrapper
Jul 15, 2026
Merged

feat(chainspec): wrap upstream tempo chainspec#653
0xKitsune merged 13 commits into
mainfrom
kit/tempo-chainspec-wrapper

Conversation

@0xKitsune

@0xKitsune 0xKitsune commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

This PR updates ZoneChainSpec to wrap the upstream Tempo chainspec, making it aware of both the Tempo and Zone hardfork schedules.

Ref #626

@0xKitsune
0xKitsune marked this pull request as ready for review July 14, 2026 20:36
@0xKitsune
0xKitsune requested a review from mattsse as a code owner July 14, 2026 20:36

@0xrusowsky 0xrusowsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good directionally, but left a suggestion and a question

Comment thread crates/evm/src/lib.rs Outdated
Comment thread crates/node/src/node.rs Outdated
@0xKitsune
0xKitsune marked this pull request as draft July 14, 2026 20:53
@0xKitsune
0xKitsune marked this pull request as ready for review July 14, 2026 21:25
Comment thread crates/evm/src/lib.rs
0xrusowsky
0xrusowsky previously approved these changes Jul 14, 2026
@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff, but this repository configures allow-self-reviews: false, so the current head commit author cannot approve their own changes. Your review did not trigger an approval prompt and is not counted toward this PR.

Ask another reviewer to +1 the PR (or submit an "Approve" review) to satisfy the gate.

@adityapk00 adityapk00 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @adityapk00 — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

adityapk00
adityapk00 previously approved these changes Jul 14, 2026
@0xKitsune
0xKitsune enabled auto-merge July 14, 2026 22:52
@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

Timing note: GitHub delivered this webhook 6.1 seconds after the review approval was created. Try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff but no live Voight-Kampff agent connection received it, so Voight-Kampff sent a push fallback. The push was not approved before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

Timing note: GitHub delivered this webhook 6.4 seconds after the review approval was created. Try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff, but another unexpired approval request is already waiting for your account. Your review did not trigger an approval prompt and is not counted toward this PR.

Wait for the current prompt to be approved, rejected, or expire, then re-submit the review to send a fresh approval request.

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@tempo-voight-kampff

Copy link
Copy Markdown

Hi @0xrusowsky — your review approval was detected by Voight-Kampff and a prompt was sent to your registered device, but no response came back before the approval window closed. Your review did not count toward this PR.

You can also try approving the PR directly via CLI with

vk approve pr https://github.com/tempoxyz/zones/pull/653

@0xKitsune
0xKitsune added this pull request to the merge queue Jul 15, 2026
Merged via the queue into main with commit f1b5289 Jul 15, 2026
16 checks passed
@0xKitsune
0xKitsune deleted the kit/tempo-chainspec-wrapper branch July 15, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants