Skip to content

fix: deserialize key_authorization in fee payer envelope decode#120

Merged
brendanjryan merged 4 commits intomainfrom
georgen/fix-pyright-key-auth
Apr 14, 2026
Merged

fix: deserialize key_authorization in fee payer envelope decode#120
brendanjryan merged 4 commits intomainfrom
georgen/fix-pyright-key-auth

Conversation

@decofe
Copy link
Copy Markdown
Member

@decofe decofe commented Apr 14, 2026

  • Deserialize key_authorization RLP bytes to SignedKeyAuthorization in decode_fee_payer_envelope
  • Deserialize sender_sig bytes to Signature in _cosign_as_fee_payer
  • Update test fixtures to use typed Signature objects instead of raw bytes
  • Fixes pyright CI and 6 pre-existing test failures on main

Prompted by: georgen

decode_fee_payer_envelope was returning raw RLP bytes for key_authorization,
but TempoTransaction expects SignedKeyAuthorization. Deserialize properly.

Co-Authored-By: grandizzy <38490174+grandizzy@users.noreply.github.com>
@grandizzy grandizzy requested a review from brendanjryan April 14, 2026 07:44
Co-Authored-By: grandizzy <38490174+grandizzy@users.noreply.github.com>
@grandizzy grandizzy marked this pull request as draft April 14, 2026 07:46
- Deserialize sender_sig bytes to Signature in _cosign_as_fee_payer
- Update test fixtures to use Signature(r=1, s=1, v=27) instead of raw bytes

Co-Authored-By: grandizzy <38490174+grandizzy@users.noreply.github.com>
@grandizzy grandizzy marked this pull request as ready for review April 14, 2026 07:53
@brendanjryan brendanjryan merged commit 1e74fef into main Apr 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants