spec: add challenge-binding secret guidance#233
Conversation
Spec Preview
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b876e6d96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| | Field | Type | Required | Description | | ||
| |-------|------|----------|-------------| | ||
| | `methodDetails.chainId` | number | OPTIONAL | Tempo chain ID. If omitted, the default value is 4217 (Tempo mainnet). | |
There was a problem hiding this comment.
chainId default consistent across method drafts
This draft sets the implicit methodDetails.chainId default to 4217, but existing Tempo method specs still default to 42431 (see specs/methods/tempo/draft-tempo-charge-00.md line 154 and specs/methods/tempo/draft-tempo-session-00.md line 543). When clients omit chainId and reuse shared Tempo defaults, subscription credentials will be signed/validated on a different chain than charge/session flows, causing verification failures or settlement on an unintended network; the default should be aligned or made explicitly required here.
Useful? React with 👍 / 👎.
brendanjryan
force-pushed
the
brendan/add-challenge-binding-secret-guidance
branch
from
9b876e6 to
5d1feb2
Compare
1 participant
Summary
Testing