feat: handle merged WWW-Authenticate challenges#170
Open
stevencartavia wants to merge 3 commits intotempoxyz:mainfrom
Open
feat: handle merged WWW-Authenticate challenges#170stevencartavia wants to merge 3 commits intotempoxyz:mainfrom
stevencartavia wants to merge 3 commits intotempoxyz:mainfrom
Conversation
stevencartavia
requested review from
Slokh,
brendanjryan,
mattsse and
onbjerg
as code owners
brendanjryan
requested changes
Mar 27, 2026
Collaborator
There was a problem hiding this comment.
Thank you! One comment re: compatability of splitting
--
The splitter only ends a Payment challenge when it finds the next Payment.
This breaks valid headers where Payment is followed by another scheme:
Payment id="a", realm="api", method="tempo", intent="charge", request="e30", Basic realm="login"
brendanjryan
approved these changes
Mar 29, 2026
Collaborator
|
@stevencartavia can you rebase and add a changelog so that we can merge? |
stevencartavia
force-pushed
the
multi-method-402
branch
from
ec0cf94 to
19c91bd
Compare
stevencartavia
force-pushed
the
multi-method-402
branch
2 times, most recently
from
80abaf1 to
ae9c7de
Compare
…dle leading whitespace Amp-Thread-ID: https://ampcode.com/threads/T-019d65cc-0e1d-7279-a3c2-1b98ac866fbf Co-authored-by: Amp <amp@ampcode.com>
stevencartavia
force-pushed
the
multi-method-402
branch
from
ae9c7de to
e1f3aa1
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019d65cc-0e1d-7279-a3c2-1b98ac866fbf Co-authored-by: Amp <amp@ampcode.com>
Contributor
Author
|
#185 overlapped most of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support 402 responses with multiple payment challenges across one or more
WWW-Authenticateheaders.