Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 418480525d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
go.mod
Outdated
| golang.org/x/sys v0.36.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/tempoxyz/tempo-go => ../tempo-go |
There was a problem hiding this comment.
The committed replace github.com/tempoxyz/tempo-go => ../tempo-go hard-codes a sibling path that is not present in a normal checkout, so go build/go test fail with a missing replacement directory unless developers recreate your local folder layout. This blocks CI and external consumers running the repo directly, making the change non-portable.
Useful? React with 👍 / 👎.
| if len(fracPart) > decimals { | ||
| for _, ch := range fracPart[decimals:] { | ||
| if ch != '0' { |
There was a problem hiding this comment.
If decimals is negative, the len(fracPart) > decimals branch always executes and fracPart[decimals:] uses a negative index, which panics at runtime instead of returning an error. Because Decimals is an exported input (ChargeRequestParams / method config), a misconfiguration like -1 can crash request normalization and bring down charge handling.
Useful? React with 👍 / 👎.
1 participant
Summary
pkg/*layout used by the Tempo SDKstempo-go/pympppattern whentempo_fundAddressis not usableTesting
go test ./...make integration