fix(dialog): increase popup size and remove focus-loss auto-close#146
Open
fix(dialog): increase popup size and remove focus-loss auto-close#146
Conversation
Co-authored-by: Georgios Konstantopoulos <17802178+gakonst@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d6890-0413-7575-b72c-db7e81cb5c8b
Contributor
|
Contributor
|
commit: |
Member
|
@decofe can you read this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two popup dialog UX issues that break password manager and OTP flows.
Changes
window focuslistener. TheoffDetectClosedinterval (which detects when the user actually closes the popup) is preserved.Porto has the same issues tracked in ithacaxyz/porto but hasn't landed fixes yet. This applies the fixes to accounts first.
Prompted by: Georgios