[DT-3501] ux updates to timezone popover#3116
Draft
andrewzamojc wants to merge 5 commits intomainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Contributor
Author
|
Hey @bilal-karim . What do you think of these updates to the timezone popover? |
Member
|
@andrewzamojc Looks much better. Is there a reason we're adding System, in addition 12h/24h for the hour format? |
Contributor
Author
|
@bilal-karim The browser has a default 12/24 hour option, so choosing system mean staying in sync with your computer's setting. Sort of like how we have system for light/dark mode. Let me know if you'd like a change. |
Member
|
@andrewzamojc I don't mind it. I'm just thinking if we should just use the label instead of the icon to be consistent with 12h and 24. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR improves the UX of the timezone popover. I attempts to consolidate the option for the user and give a better scrolling experience.
also
Screenshots (if applicable) 📸
BEFORE


AFTER
BEFORE


AFTER
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?