Skip to content

[DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover#3113

Merged
andrewzamojc merged 4 commits intomainfrom
DT-3501-for-real-12-24-hour-option
Jan 26, 2026
Merged

[DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover#3113
andrewzamojc merged 4 commits intomainfrom
DT-3501-for-real-12-24-hour-option

Conversation

@andrewzamojc
Copy link
Contributor

@andrewzamojc andrewzamojc commented Jan 23, 2026

Description & motivation 💭

This PR adds 24 hour option to the time formatting popover, as well as an ISO format option. This lets the user see times in the app, formatted in different ways that they're used to.

This new functionality is reactive throughout the app thanks to the recent $timestamp function, which formats dates reactively based on the user's format preferences. 12/24 hour options are disabled for ISO format because it does not have these variants.

Screenshots (if applicable) 📸

Screenshot 2026-01-26 at 12 04 45 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

https://temporalio.atlassian.net/browse/DT-3501
https://temporalio.atlassian.net/browse/DT-3505

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
holocene Ready Ready Preview, Comment Jan 26, 2026 4:50pm

Request Review

@andrewzamojc andrewzamojc changed the base branch from main to DT-3501-format-function-as-rune January 23, 2026 21:28
@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 23, 2026

Warnings
⚠️

📊 Strict Mode: 1 error in 1 file (0.4% of 279 total)

src/lib/utilities/format-date.ts (1)
  • L157:3: Function lacks ending return statement and return type does not include 'undefined'.

Generated by 🚫 dangerJS against 35da245

Base automatically changed from DT-3501-format-function-as-rune to main January 26, 2026 16:40
@andrewzamojc andrewzamojc force-pushed the DT-3501-for-real-12-24-hour-option branch from 212d6d4 to 35da245 Compare January 26, 2026 16:49
@andrewzamojc andrewzamojc marked this pull request as ready for review January 26, 2026 17:10
@andrewzamojc andrewzamojc changed the title [DT-3501] 12/24 hour and ISO formats added to timezone popover [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover Jan 26, 2026
Comment on lines +179 to +183
<ToggleButton
size="xs"
active={$timestampFormat === 'iso'}
on:click={() => setTimestampFormat('iso')}>ISO</ToggleButton
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially thought we might need a different sort of control for this as the list grew, however it seems to work fine. May just want to run by design.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure. I've got some UX tweaks I'd like to propose after this PR and I'll get UX looped in on those.

@andrewzamojc andrewzamojc merged commit faa48e2 into main Jan 26, 2026
20 checks passed
@andrewzamojc andrewzamojc deleted the DT-3501-for-real-12-24-hour-option branch January 26, 2026 20:44
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)
laurakwhit added a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)

Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants