CHASM engine to pass back created flag on NewExecution #8873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fretz12
force-pushed
the
fredtzeng/chasm-new-exec-create-flag
branch
from
0b9f6a9 to
9b69fc2
Compare
yycptt
reviewed
Dec 23, 2025
yycptt
approved these changes
Dec 23, 2025
yycptt
approved these changes
Jan 2, 2026
Co-authored-by: Yichao Yang <yycptt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a return flag on the NewExecution function to indicate if a new execution was actually created. Also added docs to NewExecution. Changed standalone activity on start to pass back started flag if new exec was actually created.
Why?
On NewExecution today if we use BusinessIDConflictPolicyUseExisting, we need a way to distinguish whether something is newly created or not. Based on that flag, caller code can react differently.
For standalone activity, we must pass back the started flag according to whether a new exec was actually started, to matching existing workflow behavior.
How did you test it?