-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add external payload stats to DescribeWorkflowExecution #8800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simvlad
wants to merge
4
commits into
simvlad/payload-size-stats-for-workflow-execution
Choose a base branch
from
simvlad/keep-payload-size-stats
base: simvlad/payload-size-stats-for-workflow-execution
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add external payload stats to DescribeWorkflowExecution #8800
simvlad
wants to merge
4
commits into
simvlad/payload-size-stats-for-workflow-execution
from
simvlad/keep-payload-size-stats
+95
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simvlad
commented
Dec 11, 2025
go.mod
Outdated
| modernc.org/mathutil v1.7.1 // indirect | ||
| modernc.org/memory v1.11.0 // indirect | ||
| ) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API change is not released yet. Will remove this before merging this PR.
9390400 to
c7d356a
Compare
83fdd73 to
ed0351f
Compare
3e27b5d to
50db776
Compare
0a7f12f to
cd9da5f
Compare
c6237a3 to
dc31bb8
Compare
570b464 to
4beda2c
Compare
yycptt
approved these changes
Dec 22, 2025
dc31bb8 to
ac1098d
Compare
a761772 to
23a115b
Compare
2f2c759 to
b67ab26
Compare
23a115b to
e10a9f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added external payload stats (size and count) to DescribeWorkflowExecution. Also change and add functional tests. This PR depends on Server PR #8775 and API PR temporalio/api#689.
Why?
We'd like to surface the external payload stats when DescribeWorkflowExecution is called to see how many and what size of external payloads the workflow is referencing. Numbers are coming from the workflow mutable state. This is similar to how the HistorySize is kept.
How did you test it?