Skip to content

Conversation

@simvlad
Copy link
Contributor

@simvlad simvlad commented Dec 11, 2025

What changed?

Added external payload stats (size and count) to DescribeWorkflowExecution. Also change and add functional tests. This PR depends on Server PR #8775 and API PR temporalio/api#689.

Why?

We'd like to surface the external payload stats when DescribeWorkflowExecution is called to see how many and what size of external payloads the workflow is referencing. Numbers are coming from the workflow mutable state. This is similar to how the HistorySize is kept.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@simvlad simvlad requested review from a team as code owners December 11, 2025 18:56
@simvlad simvlad changed the base branch from main to simvlad/payload-size-stats-for-workflow-execution December 11, 2025 18:57
go.mod Outdated
modernc.org/mathutil v1.7.1 // indirect
modernc.org/memory v1.11.0 // indirect
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API change is not released yet. Will remove this before merging this PR.

@simvlad simvlad requested review from jmaeagle99 and yycptt December 11, 2025 18:58
@simvlad simvlad force-pushed the simvlad/payload-size-stats-for-workflow-execution branch from 9390400 to c7d356a Compare December 15, 2025 21:03
@simvlad simvlad force-pushed the simvlad/keep-payload-size-stats branch from 83fdd73 to ed0351f Compare December 15, 2025 21:09
@simvlad simvlad changed the title Add external payload stats to WorkflowTaskStartedEvent and DescribeWorkflowExecution Add external payload stats to DescribeWorkflowExecution Dec 16, 2025
@awln-temporal awln-temporal self-requested a review December 17, 2025 23:27
@simvlad simvlad force-pushed the simvlad/payload-size-stats-for-workflow-execution branch from 3e27b5d to 50db776 Compare December 18, 2025 19:46
@simvlad simvlad force-pushed the simvlad/keep-payload-size-stats branch from 0a7f12f to cd9da5f Compare December 18, 2025 19:59
@simvlad simvlad force-pushed the simvlad/payload-size-stats-for-workflow-execution branch from c6237a3 to dc31bb8 Compare December 18, 2025 21:41
@simvlad simvlad force-pushed the simvlad/keep-payload-size-stats branch 2 times, most recently from 570b464 to 4beda2c Compare December 18, 2025 22:31
@simvlad simvlad force-pushed the simvlad/payload-size-stats-for-workflow-execution branch from dc31bb8 to ac1098d Compare January 2, 2026 19:18
@simvlad simvlad force-pushed the simvlad/keep-payload-size-stats branch 2 times, most recently from a761772 to 23a115b Compare January 2, 2026 20:10
@simvlad simvlad force-pushed the simvlad/payload-size-stats-for-workflow-execution branch 2 times, most recently from 2f2c759 to b67ab26 Compare January 3, 2026 03:24
@simvlad simvlad force-pushed the simvlad/keep-payload-size-stats branch from 23a115b to e10a9f5 Compare January 3, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants