Fix change tracking + improve fairness migration tests #8556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majiru
approved these changes
Oct 28, 2025
chaptersix
pushed a commit
that referenced
this pull request
Oct 30, 2025
## What changed? - Fix last change tracking for pri/fairness tasks. - Don't allow migration for sticky queues. - Improve fairness migration tests: - Set config only on test task queue - Use only ApproximateBacklogCount ## Why? This fixes some situations where we wouldn't update ApproximateBacklogCount on partition unload. It should also make the test less flaky. ## How did you test it? - [x] covered by existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
This fixes some situations where we wouldn't update ApproximateBacklogCount on partition unload. It should also make the test less flaky.
How did you test it?