No-op close transfer task for SyncWorkflowState #8507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaely520
changed the title
xwduan
approved these changes
Oct 28, 2025
chaptersix
pushed a commit
that referenced
this pull request
Oct 30, 2025
## What changed?
No-oping close transfer tasks for SyncWorkflowState tasks
## Why?
We need non state based replication to be eligible for this
optimization.
## How did you test it?
- [x] built
- [x] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [x] added new functional test(s)
`go test -v -tags test_dep ./tests/xdc -run
TestStreamBasedReplicationTestSuite/DisableTransitionHistory/TestCloseTransferTaskAckedReplication
-timeout 10m -count=1`
shows
`2025-10-20T08:15:08.290-0700 info Skipping close transfer task
generation - already acked on active cluster {"cluster-name":
"standby_aadnd", "host": "127.0.0.1:57179", "shard-id": 1, "address":
"127.0.0.1:57179", "wf-namespace-id":
"e550305e-0b43-4bcd-a490-8e3223f51ce1", "wf-id":
"test-replication-e2c094d3-c34f-42d9-a166-a967d4e7f602", "wf-run-id":
"019a0230-299a-74ba-a31f-ac247c05f2b9", "logging-call-at":
"/Users/michaely520/projects/temporal/service/history/workflow/task_generator.go:206"}
stream_based_replication_test.go:975: Verified IsCloseTransferTaskAcked
and IsForceReplication flags in SyncWorkflowStateTask`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
No-oping close transfer tasks for SyncWorkflowState tasks
Why?
We need non state based replication to be eligible for this optimization.
How did you test it?
go test -v -tags test_dep ./tests/xdc -run TestStreamBasedReplicationTestSuite/DisableTransitionHistory/TestCloseTransferTaskAckedReplication -timeout 10m -count=1shows
2025-10-20T08:15:08.290-0700 info Skipping close transfer task generation - already acked on active cluster {"cluster-name": "standby_aadnd", "host": "127.0.0.1:57179", "shard-id": 1, "address": "127.0.0.1:57179", "wf-namespace-id": "e550305e-0b43-4bcd-a490-8e3223f51ce1", "wf-id": "test-replication-e2c094d3-c34f-42d9-a166-a967d4e7f602", "wf-run-id": "019a0230-299a-74ba-a31f-ac247c05f2b9", "logging-call-at": "/Users/michaely520/projects/temporal/service/history/workflow/task_generator.go:206"} stream_based_replication_test.go:975: Verified IsCloseTransferTaskAcked and IsForceReplication flags in SyncWorkflowStateTask