Add MSPointer to CHASM framework #8485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Oct 16, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Had some comments but non of them are blocking.
chasm/lib/workflow/workflow.go
Outdated
Comment on lines
18
to
19
| // State of the workflow is managed by mutable_state_impl, not CHASM engine, so this will always be empty. | ||
| State proto.Message |
Member
There was a problem hiding this comment.
Suggested change
| // State of the workflow is managed by mutable_state_impl, not CHASM engine, so this will always be empty. | |
| State proto.Message | |
| // State of the workflow is managed by mutable_state_impl, not CHASM engine, so this will always be empty. | |
| *emptypb.Empty |
| State proto.Message | ||
|
|
||
| // MSPointer is a special in-memory field for getting mutable state access. | ||
| MSPointer chasm.MSPointer |
Member
There was a problem hiding this comment.
No other component is allowed to have this pointer and this is really just a transitional artifact (even if the transition may take years).
Member
There was a problem hiding this comment.
Ideally the CHASM framework would panic if any other component tried to use this hack.
|
|
||
| if ms.chasmEnabled() { | ||
| // Initialize chasm tree once for new workflows. | ||
| mutableContext := chasm.NewMutableContext(context.TODO(), ms.chasmTree.(*chasm.Node)) |
Member
| s.nodeBackend.EXPECT().GetCurrentVersion().Return(int64(1)).AnyTimes() | ||
| s.nodeBackend.EXPECT().UpdateWorkflowStateStatus(gomock.Any(), gomock.Any()).Return(true, nil).AnyTimes() | ||
| s.nodeBackend.EXPECT().GetWorkflowKey().Return(tv.Any().WorkflowKey()).AnyTimes() | ||
| s.nodeBackend.EXPECT().IsWorkflow().Return(false).AnyTimes() |
Member
There was a problem hiding this comment.
@lina-temporal, @yycptt this is what you get when you use these tight mocks, every little behavior change needs to be propagated to every test in the codebase.
yycptt
added a commit
that referenced
this pull request
Oct 27, 2025
## What changed? - Wire up chasm workflow library ## Why? - #8485 makes workflow start to use CHASM as well and we need to register workflow as a chasm library. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks - Logic is only used when chasm feature flag is turned on. The change is mainly for functional tests.
chaptersix
pushed a commit
that referenced
this pull request
Oct 30, 2025
## What changed? - Wire up chasm workflow library ## Why? - #8485 makes workflow start to use CHASM as well and we need to register workflow as a chasm library. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks - Logic is only used when chasm feature flag is turned on. The change is mainly for functional tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new special
MSPointertype to the CHASM frameworkWhy?
To support components invoking methods from the underlying mutable state. Specifically, Nexus callbacks will need to get the Nexus completion from the mutable state.
How did you test it?
updated unit tests