Skip to content

Improve multi-cursor actions #8416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yycptt merged 4 commits into from
Oct 3, 2025
Merged

Improve multi-cursor actions #8416

yycptt merged 4 commits into from
Oct 3, 2025

Conversation

@yycptt
Copy link
Member

@yycptt yycptt commented Oct 1, 2025 •
edited
Loading

What changed?

  • Introduced a new "move (task) group" action replacing the "incorrect" slice-predicate action. See inline comment for how it works.
  • Improve task Predicate AND/OR calculation to reduce predicate size.
  • Skip empty slices when adding queue slices to readers.

Why?

  • Better namespace isolation.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • The new action can be disabled via dc.

@yycptt yycptt requested a review from prathyushpv October 1, 2025 23:45
@yycptt yycptt force-pushed the improve-multi-cursor branch from 6699081 to 6ea7ad8 Compare October 2, 2025 22:41
@yycptt yycptt changed the title [WIP] Improve multi-cursor actions Improve multi-cursor actions Oct 3, 2025
@yycptt yycptt marked this pull request as ready for review October 3, 2025 01:00
@yycptt yycptt requested review from a team as code owners October 3, 2025 01:00
@yycptt yycptt merged commit b87fb75 into temporalio:main Oct 3, 2025
58 checks passed
@yycptt yycptt deleted the improve-multi-cursor branch October 3, 2025 05:48
@yycptt yycptt mentioned this pull request Oct 27, 2025
Merged
6 tasks
yiminc pushed a commit that referenced this pull request Oct 27, 2025
@yycptt
Fix queue slice count action (#8550)
651d959 
## What changed?
- Revert the removal of slice count check in multi-cursor slice count
action.
- The check was incorrectly removed in [#8416
L117](https://github.com/temporalio/temporal/pull/8416/files#diff-deecce1e374d8c4db074d9c923c2b80d1b8e28cef778202aa01397e8d56e1bafL117)

## Why?
- Without the check, the code will panic later in
`pickCompactCandidates` when currentSliceCount < targetSliceCount.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
- [x] will follow up with a test PR
deepakkarki pushed a commit that referenced this pull request Oct 27, 2025
@yycptt @deepakkarki
Fix queue slice count action (#8550)
1dda15b 
## What changed?
- Revert the removal of slice count check in multi-cursor slice count
action.
- The check was incorrectly removed in [#8416
L117](https://github.com/temporalio/temporal/pull/8416/files#diff-deecce1e374d8c4db074d9c923c2b80d1b8e28cef778202aa01397e8d56e1bafL117)

## Why?
- Without the check, the code will panic later in
`pickCompactCandidates` when currentSliceCount < targetSliceCount.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
- [x] will follow up with a test PR
temporal-cicd bot pushed a commit that referenced this pull request Oct 27, 2025
@yycptt @temporal-cicd
Fix queue slice count action (#8550)
28941c3 
## What changed?
- Revert the removal of slice count check in multi-cursor slice count
action.
- The check was incorrectly removed in [#8416
L117](https://github.com/temporalio/temporal/pull/8416/files#diff-deecce1e374d8c4db074d9c923c2b80d1b8e28cef778202aa01397e8d56e1bafL117)

## Why?
- Without the check, the code will panic later in
`pickCompactCandidates` when currentSliceCount < targetSliceCount.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
- [x] will follow up with a test PR
chaptersix pushed a commit that referenced this pull request Oct 30, 2025
@yycptt @chaptersix
Fix queue slice count action (#8550)
ecf3887 
## What changed?
- Revert the removal of slice count check in multi-cursor slice count
action.
- The check was incorrectly removed in [#8416
L117](https://github.com/temporalio/temporal/pull/8416/files#diff-deecce1e374d8c4db074d9c923c2b80d1b8e28cef778202aa01397e8d56e1bafL117)

## Why?
- Without the check, the code will panic later in
`pickCompactCandidates` when currentSliceCount < targetSliceCount.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
- [x] will follow up with a test PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prathyushpv prathyushpv prathyushpv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yycptt @prathyushpv