Skip to content

Pass through original HTTP headers for forwarded Nexus requests #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 20, 2025

Conversation

pdoerner
Copy link
Contributor

What changed?

When forwarding Nexus Start/Cancel requests, the original HTTP headers will be passed through without sanitization.

Why?

Some headers that are still needed for the forwarded request may be sanitized during original request processing (e.g. authorization information headers).

How did you test it?

existing tests

@pdoerner pdoerner requested a review from a team as a code owner August 18, 2025 19:15
@pdoerner pdoerner requested a review from bergundy August 18, 2025 19:34
@bergundy
Copy link
Member

Worth testing that stripped headers are visible after forwarding.

@pdoerner pdoerner enabled auto-merge (squash) August 20, 2025 22:12
@pdoerner pdoerner merged commit 1d340f5 into main Aug 20, 2025
58 checks passed
@pdoerner pdoerner deleted the nexus-forward-original-headers branch August 20, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants