Support NexusOperationCancelRequest[Completed|Failed] events #7564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
approved these changes
Apr 7, 2025
pdoerner
added a commit
to pdoerner/temporal
that referenced
this pull request
Apr 23, 2025
…emporalio#7564)" This reverts commit 299e332.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added support for the new
NexusOperationCancelRequestCompletedandNexusOperationCancelRequestFailedevents which were added in temporalio/api#564These events are marked with
WorkerMayIgnore=truefor compatibility with older SDKs.Why?
These events are used to support the new "wait cancellation requested" Nexus operation cancellation type.
How did you test it?
Updated functional tests.