Delete Namespace: fix incompatible change in reclaim resources workflow#7385
Merged
alexshtin merged 1 commit intotemporalio:mainfrom Feb 26, 2025
Merged
Conversation
rodrigozhou
reviewed
Feb 25, 2025
| if err != nil { | ||
| return result, err | ||
| // TODO: remove version check and 9s const after v1.27 release. | ||
| namespaceCacheRefreshDelay := 9 * time.Second |
yiminc
approved these changes
Feb 25, 2025
rodrigozhou
pushed a commit
that referenced
this pull request
Feb 26, 2025
…ow (#7385) ## What changed? <!-- Describe what has changed in this PR --> #7215 introduced incompatible change in reclaim resources workflow code (extra local activity call). If new version is rolled out while previous workflow is running, it will generate NDE. This PR adds proper version check (patch API) to avoid it. ## Why? <!-- Tell your future self why have you made these changes --> Bug fix. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Run upgrade locally. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No risks. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> No. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> Yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
#7215 introduced incompatible change in reclaim resources workflow code (extra local activity call). If new version is rolled out while previous workflow is running, it will generate NDE. This PR adds proper version check (patch API) to avoid it.
Why?
Bug fix.
How did you test it?
Run upgrade locally.
Potential risks
No risks.
Documentation
No.
Is hotfix candidate?
Yes.