Use modernc.org/sqlite version v1.34.1 #7333
Conversation
Makefile
Outdated
| endif | ||
|
|
||
| PINNED_DEPENDENCIES := \ | ||
| modernc.org/sqlite@v1.34.0 |
There was a problem hiding this comment.
Please document why this is pinned.
There was a problem hiding this comment.
Can we also pin to a more recent patch or does it have to be 1.34.0?
There was a problem hiding this comment.
We can use v1.34.1. v1.34.2 has the problematic commit
|
Not sure how big of an issue is, but the package docs has this:
In v1.34.1, they use |
rodrigozhou
changed the title
Thanks @rodrigozhou for finding that! I have pinned libc to this version as well. |
## What changed? Use version v1.34.1 of modernc.org/sqlite library. ## Why? We had fixed an issue with contexts being cancelled during a transaction. But a later change in this library reintroduced this issue. While we work with the maintainer to fix this, use the previous version. ## How did you test it? ## Potential risks ## Documentation ## Is hotfix candidate? No
## What was changed <!-- Describe what has changed in this PR --> Pinned v1.34.1 for modernc/sqlite ## Why? <!-- Tell your future self why have you made these changes --> 1.34.2 has a regression, waiting on https://gitlab.com/cznic/sqlite/-/issues/196 to be resolved. See temporalio/temporal#7333 for more details ## Checklist <!--- add/delete as needed ---> 1. Closes #777 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
## What was changed Wiring in new enableReplication flag into cluster upsert cli. Deleting sql pinning test as we no longer need this, see historical context: #784 temporalio/temporal#7333 then unpinning in OSS temporalio/temporal#8489 ## Why? Allows for users to leverage the new field ## Checklist 1. Closes 2. How was this tested: built locally and tested in conjunction with temporalio/temporal#8744, used the cli manually to make a replication based test pass
What changed?
Use version v1.34.1 of modernc.org/sqlite library.
Why?
We had fixed an issue with contexts being cancelled during a transaction. But a later change in this library reintroduced this issue.
While we work with the maintainer to fix this, use the previous version.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?
No