OTEL persistence context deadline #7208
Merged
+869
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
otel-timeout-ctx
branch
from
6a88f00 to
439bb79
Compare
stephanos
force-pushed
the
otel-timeout-ctx
branch
from
439bb79 to
2c3ff10
Compare
stephanos
force-pushed
the
otel-timeout-ctx
branch
from
2c3ff10 to
1d1bdcb
Compare
stephanos
commented
Jan 31, 2025
common/telemetry/grpc.go
Outdated
| if ok { | ||
| span.SetAttributes(attribute.String("rpc.request.timeout", deadline.Format(time.RFC3339Nano))) | ||
| if deadline, ok := ctx.Deadline(); ok { | ||
| span.SetAttributes(attribute.Int64("rpc.request.deadline", deadline.UnixNano())) |
There was a problem hiding this comment.
I realized "deadline" is clearer. And UnixNano seems like a better choice, too.
There was a problem hiding this comment.
I think both of them make sense. "timeout" should be a duration though. deadline-now.
alexshtin
approved these changes
Feb 5, 2025
common/telemetry/grpc.go
Outdated
| if ok { | ||
| span.SetAttributes(attribute.String("rpc.request.timeout", deadline.Format(time.RFC3339Nano))) | ||
| if deadline, ok := ctx.Deadline(); ok { | ||
| span.SetAttributes(attribute.Int64("rpc.request.deadline", deadline.UnixNano())) |
There was a problem hiding this comment.
I think both of them make sense. "timeout" should be a duration though. deadline-now.
|
Example output after the recent change: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added "persistence.deadline" attributes to OTEL persistence span.
Why?
Add more details for debugging.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?