add more activity timeout tests #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Dec 12, 2024
| @@ -271,27 +271,42 @@ func (s *ActivityClientTestSuite) Test_ActivityTimeouts() { | |||
| f3 := workflow.ExecuteActivity(ctx3, activityFn) | |||
|
|
|||
| ctx4 := workflow.WithActivityOptions(ctx, workflow.ActivityOptions{ | |||
| ActivityID: "ScheduleToCloseNotSet", | |||
There was a problem hiding this comment.
Have you considered test cases and sub tests approach? It makes tests more verbose.
bergundy
pushed a commit
that referenced
this pull request
Dec 17, 2024
## What changed? <!-- Describe what has changed in this PR --> We didn't test scenarios when one of the timeouts is not provided. ## Why? <!-- Tell your future self why have you made these changes --> To increase test scenario coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We didn't test scenarios when one of the timeouts is not provided.
Why?
To increase test scenario coverage.