Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic hooks for testing #6938

Merged
merged 16 commits into from
Jan 18, 2025
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:temporalio/temporal into david/ei
  • Loading branch information
dnr committed Jan 17, 2025
commit 91193a24a415c12c2184b6c717f0703b9666ae08
4 changes: 2 additions & 2 deletions service/history/api/multioperation/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ func (mo *multiOp) Invoke(ctx context.Context) (*historyservice.ExecuteMultiOper

testhooks.Call(testHooks, testhooks.UpdateWithStartInBetweenLockAndStart)

// workflow hasn't been started yet: start and then apply update
resp, err := startAndUpdateWorkflow(ctx, starter, updater)
// Workflow hasn't been started yet ...
resp, err := mo.startAndUpdateWorkflow(ctx)
var noStartErr *noStartError
if errors.As(err, &noStartErr) {
// The workflow was meant to be started - but was actually *not* started.
Expand Down
3 changes: 3 additions & 0 deletions tests/testcore/functional_test_base.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ import (
"go.temporal.io/server/common/primitives"
"go.temporal.io/server/common/primitives/timestamp"
"go.temporal.io/server/common/rpc"
"go.temporal.io/server/common/testing/historyrequire"
"go.temporal.io/server/common/testing/protorequire"
"go.temporal.io/server/common/testing/testhooks"
"go.temporal.io/server/common/testing/updateutils"
"go.temporal.io/server/environment"
"go.uber.org/fx"
"gopkg.in/yaml.v3"
Expand Down
1 change: 1 addition & 0 deletions tests/testcore/onebox.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ import (
"go.temporal.io/server/common/rpc/encryption"
"go.temporal.io/server/common/sdk"
"go.temporal.io/server/common/searchattribute"
"go.temporal.io/server/common/telemetry"
"go.temporal.io/server/common/testing/testhooks"
"go.temporal.io/server/service/frontend"
"go.temporal.io/server/service/history"
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.