Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test runner improvements #6865

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Test runner improvements #6865

merged 2 commits into from
Nov 22, 2024

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Nov 21, 2024 •
edited
Loading

What changed?

  • Do not rerun tests if there are more than 10 failures in a single suite. This threshold can later become configurable as needed.
  • Add a sanity check to ensure test-runner reruns all failed tests as expected.

Why?

For confidence, this is a new tool and I don't trust it yet. The threshold is

@bergundy bergundy requested a review from a team as a code owner November 21, 2024 22:07
@bergundy bergundy changed the title Add a sanity check to ensure test-runner reruns all failed tests as expected Test runner improvements Nov 21, 2024
@bergundy bergundy requested review from stephanos, alexshtin, Alex-Tideman and ychebotarev and removed request for Alex-Tideman November 22, 2024 00:37
@bergundy bergundy merged commit b2f5cb3 into temporalio:main Nov 22, 2024
49 checks passed
@bergundy bergundy deleted the sanity-check-test-runner branch November 22, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanos stephanos stephanos approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

@ychebotarev ychebotarev Awaiting requested review from ychebotarev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergundy @stephanos