Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nexus_workflow_test: Use assert instead of require in EventuallyWithT blocks #6687

Merged
merged 1 commit into from
Oct 22, 2024
Merged

nexus_workflow_test: Use assert instead of require in EventuallyWithT blocks #6687

merged 1 commit into from
Oct 22, 2024

Conversation

bergundy
Copy link
Member

Why?

require makes tests panic in eventually blocks.

@bergundy bergundy requested a review from a team as a code owner October 22, 2024 16:32
@bergundy bergundy merged commit f0a9d6f into temporalio:main Oct 22, 2024
48 checks passed
@bergundy bergundy deleted the nexus-test-fix branch October 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivs11 Shivs11 Shivs11 left review comments

@gow gow gow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergundy @gow @Shivs11