Nexus: Better handling of nil and empty payloads #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdoerner
approved these changes
Oct 7, 2024
bergundy
force-pushed
the
nexus-nil-and-empty-result-fix
branch
from
9480f68 to
3f7a4fb
Compare
gow
approved these changes
Oct 7, 2024
| ev, err := history.Next() | ||
| s.NoError(err) | ||
| if attr := ev.GetNexusOperationCompletedEventAttributes(); attr != nil { | ||
| protorequire.ProtoEqual(s.T(), s.mustToPayload(nil), attr.GetResult()) |
There was a problem hiding this comment.
nit: s.EqualExportedValues() does the same without custom code.
There was a problem hiding this comment.
I'm not sure this works for protos. protorequire was developed specifically for proto comparison when we transitioned from gogo to google proto.
xwduan
pushed a commit
that referenced
this pull request
Oct 18, 2024
## What changed? Improve conversion of payloads with empty metadata and nil workflow results to Nexus Content. NOTE: This also upgrades the Go SDK from 1.27.0 to 1.29.1 to test Nexus via the SDK. ## Why? Handle a couple of edge cases that weren't properly handled before. The fix in `mutable_state_impl.go` is the more critical one and may cause surprising behavior in the SDKs. ## How did you test it? Added tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Improve conversion of payloads with empty metadata and nil workflow results to Nexus Content.
NOTE: This also upgrades the Go SDK from 1.27.0 to 1.29.1 to test Nexus via the SDK.
Why?
Handle a couple of edge cases that weren't properly handled before.
The fix in
mutable_state_impl.gois the more critical one and may cause surprising behavior in the SDKs.How did you test it?
Added tests.