Fix SQL visibility root workflow fields in schema #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
rodrigozhou/fix-vis-schema-root-wf
branch
from
2caa9ba to
a1d21aa
Compare
alexshtin
approved these changes
Jun 5, 2024
stephanos
pushed a commit
that referenced
this pull request
Jun 5, 2024
## What changed? <!-- Describe what has changed in this PR --> Fix SQL visibility root workflow fields in schema: they are supposed to be not null. ## Why? <!-- Tell your future self why have you made these changes --> The schema set the root workflow fields as nullable, but the code was assuming to be not null. GH Issue: #6050 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Start Temporal v1.23.1, create some workflows, update the schemas in v1.24.0, upgrade Temporal v1.24.0: - reproduced the error - applied this fix, and the error was gone. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix SQL visibility root workflow fields in schema: they are supposed to be not null.
Why?
The schema set the root workflow fields as nullable, but the code was assuming to be not null.
GH Issue: #6050
How did you test it?
Start Temporal v1.23.1, create some workflows, update the schemas in v1.24.0, upgrade Temporal v1.24.0:
Potential risks
Documentation
Is hotfix candidate?