-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proto/api submodule #5868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your protogen version is out of date as we pin protogen in the makefile; it's separate from the Go API version in go.mod
I know, I'm waiting to do an api release so I can bump it |
What changed?
proto/api
submodule.go run
and uses the same api-go reference as the rest of the server for the source protos.Why?
How did you test it?
running commands manually a lot
Potential risks
Importing protos from somewhere other than our api and google well-known protos may require some updates to the script's import path logic.
Documentation
updated docs