Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize docs #5535

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Reorganize docs #5535

merged 6 commits into from
Mar 19, 2024

Conversation

MichaelSnowden
Copy link
Contributor

What changed?

I reorganized our docs into docs/{admin,architecture,development}.

Why?

We discussed this internally, but I believe this is a better segmentation for the different audiences looking at our docs. I plan on adding more stuff to docs/admin like metrics and dynamic config docs.

How did you test it?

I'm mainly looking for broken links.

  • I went through each markdown file in docs manually.
  • I looked through all inspection errors in the IDE.
  • I looked at all references to "docs/" or "develop/" in our code.

Potential risks

Documentation

Is hotfix candidate?

@MichaelSnowden MichaelSnowden marked this pull request as ready for review March 14, 2024 18:10
@MichaelSnowden MichaelSnowden requested a review from a team as a code owner March 14, 2024 18:10
@dnr
Copy link
Member

dnr commented Mar 14, 2024

Just curious why this shows up as all added lines? Did you not remove the old files from the old locations?

Also, nitpick: I'd prefer assets to be a non-hidden directory. Yeah, you don't need to see them when browsing, but they're going to be edited a bunch so better to have them visible

@stephanos
Copy link
Contributor

+1 to preserving the git history.

+1 to non-hidden assets folder.

@MichaelSnowden
Copy link
Contributor Author

Just curious why this shows up as all added lines? Did you not remove the old files from the old locations?

Wow, yeah I didn't delete from the previous location. I swear I used a move refactor in GoLand... Anyway, it's fixed now.

Also, nitpick: I'd prefer assets to be a non-hidden directory. Yeah, you don't need to see them when browsing, but they're going to be edited a bunch so better to have them visible

I also don't want it to be hidden, but I want it to somehow show up as separate from the other things in the docs folder. I changed the period to be an underscore.

@MichaelSnowden MichaelSnowden merged commit 676657c into main Mar 19, 2024
42 checks passed
@MichaelSnowden MichaelSnowden deleted the snowden/docs branch March 19, 2024 06:13
stephanos pushed a commit to stephanos/temporal that referenced this pull request Mar 21, 2024
## What changed?
<!-- Describe what has changed in this PR -->
I reorganized our docs into `docs/{admin,architecture,development}`.

## Why?
<!-- Tell your future self why have you made these changes -->
We discussed this internally, but I believe this is a better
segmentation for the different audiences looking at our docs. I plan on
adding more stuff to docs/admin like metrics and dynamic config docs.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
I'm mainly looking for broken links.
- I went through each markdown file in docs manually. 
- I looked through all inspection errors in the IDE.
- I looked at all references to "docs/" or "develop/" in our code.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants