Repository navigation
Conversation
Bumps go.temporal.io/api for region_ids, and go.temporal.io/sdk to v1.49.0, which that api version requires.
mani-j9
force-pushed
the
mani/ha-serverless-api
branch
from
October 9, 2026 22:26
73b373f to
7f2e903
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
region_idsbetween the compute config API (ComputeConfigScalingGroupandComputeConfigScalingGroupSummary) and the worker controller's scaling group spec, in all four conversions inservice/worker/workerdeployment/compute_util.go: create, update, spec to config and spec to summary.go.temporal.io/apito pick upregion_ids(Add region_id to ComputeConfigScalingGroup api#875).Why?
Scaling groups can list the regions they apply in (region_ids). The worker controller runs where the namespace is active and uses only the groups that list its region, so after a failover it picks the compute for the newly active region. That logic lives in temporal-auto-scaled-workers (temporalio/temporal-auto-scaled-workers#152); the server only passes region_ids through.
Depends on temporalio/temporal-auto-scaled-workers#152, which adds RegionIds to the worker controller's scaling group spec that this maps into. Once it merges, go.temporal.io/auto-scaled-workers gets bumped here; until then this doesn't compile.
How did you test it?
TestComputeConfigConversions_RegionIdsround-trips a group with two AWS regions through all four conversions.Potential risks
region_idsthere. Region-scoped groups are only available where the hosting binary supplies a region, such as Temporal Cloud.