Skip to content

allow disabling time skipping config by simply setting a nil for tsc - #12482

Merged
feiyang3cat merged 1 commit into
temporalio:mainfrom
feiyang3cat:fix-vts-chasm-minor
Oct 12, 2026
Merged

feiyang3cat merged 1 commit into
temporalio:mainfrom
feiyang3cat:fix-vts-chasm-minor

Conversation

@feiyang3cat

@feiyang3cat feiyang3cat commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

What changed?

pass a nil TSC from CHASM SetTSConfig to mutable state

Why?

easier for users to disable time skipping by just not passing a config

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@feiyang3cat
feiyang3cat marked this pull request as ready for review October 9, 2026 06:18
@feiyang3cat
feiyang3cat requested a review from a team as a code owner October 9, 2026 06:18
@awln-temporal
awln-temporal self-requested a review October 12, 2026 13:57
@feiyang3cat
feiyang3cat merged commit 71f4847 into temporalio:main Oct 12, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants