Repository navigation
Expose Per-Namespace Pending Task Metrics for Queue Move Groups - #12474
Open
exodus2512 wants to merge 2 commits into
Open
exodus2512 wants to merge 2 commits into
exodus2512 wants to merge 2 commits into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a
queue_pending_tasks_per_namespacemetric to makeper-namespace pending task counts observable for queue move groups.
The metric is recorded from the existing pending-task calculation in
actionMoveGroup, avoiding any additional task-count computation.The metric includes:
namespacetask_categoryZero pending-task counts are not emitted.
Why
The move-group mechanism uses a pending-task threshold to move noisy
task groups to dedicated readers. Previously, operators could observe
the threshold being exceeded through logs, but could not monitor the
per-namespace pending task count leading up to that threshold.
This metric makes that state observable.
Implementation
QueuePendingTasksPerNamespacedimensionless histogram.pendingTaskPerGroupvalues.namespace resolution fallback, and outbound grouper keys.
Tests
go test ./service/history/queuesgo test ./common/metricsgit diff --checkgofmtAll tests pass.
Fixes #12450