Skip to content

Add started and closed principals for CHASM root components - #12461

Open
chanric wants to merge 2 commits into
temporalio:mainfrom
chanric:richard/chasm-execution-principal
Open

chanric wants to merge 2 commits into
temporalio:mainfrom
chanric:richard/chasm-execution-principal

Conversation

@chanric

@chanric chanric commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

For auditing, we will add on root-create and component-create, started_by_principals if available For closing the root, we will stamp closed_by_principal if available

Not addressed, closed_by_principal for sub components

What changed?

Root components for CHASM now have started_by_principal and closed_by_principal by fields
Subcomponents for CHASM can now have started_by_principal

Why?

SAA customers want these fields for auditing

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • We did not add component close logs
  • We touch the proto message. The message is now larger on every write

For auditing, we will add on root-create and component-create, created by principals if available
For closing the root, we will stamp the principal if available

Not addressed, closed by for sub components
@chanric
chanric requested review from a team as code owners October 7, 2026 21:26
@chanric chanric changed the title Add created and closed principals for CHASM root components Add started and closed principals for CHASM root components Oct 7, 2026
@chanric
chanric requested a review from awln-temporal October 7, 2026 21:58
Comment thread chasm/tree.go Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants