Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceResolver interface and corresponding ServerOption #1188

Merged
merged 6 commits into from
Jan 15, 2021

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Jan 14, 2021

What changed?

  1. ServiceResolver interface.
  2. NoopResolver default implementation.
  3. WithPersistenceServiceResolver server option to specify service resolver for persistence libraries (both Cassandra and SQL).

Why?
Closes #1156.

How did you test it?
Run existing tests.

Potential risks
No risks.

@alexshtin alexshtin force-pushed the feature/service-resolver branch from c40051c to 3b3eeb1 Compare January 14, 2021 21:46
@alexshtin alexshtin force-pushed the feature/service-resolver branch from 36717af to e19962d Compare January 15, 2021 00:03
@alexshtin alexshtin requested a review from wxing1292 January 15, 2021 00:05
@alexshtin alexshtin merged commit d8c74c9 into temporalio:master Jan 15, 2021
@alexshtin alexshtin deleted the feature/service-resolver branch January 15, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a hook to specify a custom Cassandra seed node provider
2 participants