Skip unchanged current execution updates - #11713
Open
ali-khokhar-nvidia wants to merge 2 commits into
Open
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11710.
What changed?
After locking and validating a current-execution row, SQL persistence now skips
UpdateCurrentExecutionswhen every persisted field is already equal. Start times are compared at the microsecond precision used by the SQL type converters.Why?
The existing path rewrites
current_executionseven when the desired row is unchanged. Avoiding that physical update removes unnecessary WAL and tuple churn while retaining the existingFOR UPDATElock and run-ID validation.How did you test it?
The tests cover every field in
CurrentExecutionsRow, verify database timestamp precision, prove an identical row performs zero updates, and prove a changed field still performs one update.Potential risks
Only semantically identical rows skip the update. Changed state, status, identity, version, payload, encoding, or timestamp values continue through the existing update path.