Skip to content

Commit

Permalink
OTEL omit redundant persistence blobs (#7212)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->

Omitting redundant persistence data blobs.

## Why?
<!-- Tell your future self why have you made these changes -->

Since the original data is already there, serializing the blobs is not
useful. Removing it reduces noise.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
  • Loading branch information
stephanos authored Feb 5, 2025
1 parent 74e715a commit cf81c5b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions common/persistence/persistence_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,9 @@ type (
RunID string

ExecutionInfo *persistencespb.WorkflowExecutionInfo
ExecutionInfoBlob *commonpb.DataBlob
ExecutionInfoBlob *commonpb.DataBlob `json:"-"` // redundant in JSON
ExecutionState *persistencespb.WorkflowExecutionState
ExecutionStateBlob *commonpb.DataBlob
ExecutionStateBlob *commonpb.DataBlob `json:"-"` // redundant in JSON
NextEventID int64
StartVersion int64
LastWriteVersion int64
Expand Down Expand Up @@ -476,9 +476,9 @@ type (
RunID string

ExecutionInfo *persistencespb.WorkflowExecutionInfo
ExecutionInfoBlob *commonpb.DataBlob
ExecutionInfoBlob *commonpb.DataBlob `json:"-"` // redundant in JSON
ExecutionState *persistencespb.WorkflowExecutionState
ExecutionStateBlob *commonpb.DataBlob
ExecutionStateBlob *commonpb.DataBlob `json:"-"` // redundant in JSON
StartVersion int64
LastWriteVersion int64
NextEventID int64
Expand Down

0 comments on commit cf81c5b

Please sign in to comment.