Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Schedule): support query for listing schedules #1535

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

nikhilbhatia08
Copy link
Contributor

@nikhilbhatia08 nikhilbhatia08 commented Sep 25, 2024

What was changed

Added the support for query for listing schedules and added test coverage on the changes.

Why?

Checklist

  1. Closes issue

  2. How was this tested:

Added a test to the above changes as discussed with @antlai-temporal .
Created four schedules with two schedules having a search attribute key and two of them not having search attribute keys and then listing with the key ensuring I got back two of them.
549 tests passed
2 tests skipped
9 tests todo

  1. Any docs updates needed?

@nikhilbhatia08 nikhilbhatia08 requested a review from a team as a code owner September 25, 2024 15:14
@nikhilbhatia08
Copy link
Contributor Author

@mjameswh removed the duplicating block. Please review it sir.

@nikhilbhatia08
Copy link
Contributor Author

@mjameswh removed the extra code sir. Please review it sir. My apologies for small mistakes and I truly appreciate your patience and understanding sir.

@mjameswh
Copy link
Contributor

My apologies for small mistakes and I truly appreciate your patience and understanding sir.

No worry for that, a few round of these are totally expected. Thanks for your own patience, really, and thanks for your contribution.

@mjameswh
Copy link
Contributor

Another minor thing here. I believe that should be the last one.

BTW, you can run the linter yourself on your local machine. It's a good habit to run these two commands just before pushing commits to a public branch:

npm run format
npm run lint

Different Open Source projects have different tools, but most use some kind of linters.

@nikhilbhatia08
Copy link
Contributor Author

@mjameswh sir ran both the commands npm run format and npm run lint.

Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

@mjameswh mjameswh merged commit faa6422 into temporalio:main Sep 30, 2024
70 checks passed
@nikhilbhatia08 nikhilbhatia08 deleted the list-query-schedules branch October 1, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants