-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Schedule): support query for listing schedules #1535
feat(Schedule): support query for listing schedules #1535
Conversation
@mjameswh removed the duplicating block. Please review it sir. |
@mjameswh removed the extra code sir. Please review it sir. My apologies for small mistakes and I truly appreciate your patience and understanding sir. |
No worry for that, a few round of these are totally expected. Thanks for your own patience, really, and thanks for your contribution. |
Another minor thing here. I believe that should be the last one. BTW, you can run the linter yourself on your local machine. It's a good habit to run these two commands just before pushing commits to a public branch:
Different Open Source projects have different tools, but most use some kind of linters. |
@mjameswh sir ran both the commands npm run format and npm run lint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot!
What was changed
Added the support for query for listing schedules and added test coverage on the changes.
Why?
Checklist
Closes issue
How was this tested:
Added a test to the above changes as discussed with @antlai-temporal .
Created four schedules with two schedules having a search attribute key and two of them not having search attribute keys and then listing with the key ensuring I got back two of them.
549 tests passed
2 tests skipped
9 tests todo