-
Notifications
You must be signed in to change notification settings - Fork 126
feat(workflow): Expose updateId to update handlers #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antlai-temporal
merged 6 commits into
temporalio:main
from
antlai-temporal:expose-update-id
Jun 28, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5beb64a
First implementation with no tests
antlai-temporal 6edb175
Merge remote-tracking branch 'upstream/main' into expose-update-id
antlai-temporal 11904ef
Add tests
antlai-temporal 447bb20
Remove catch()
antlai-temporal e45bfae
Run prettier
antlai-temporal 3912f3f
Merge branch 'main' into expose-update-id
mjameswh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import type { AsyncLocalStorage as ALS } from 'node:async_hooks'; | ||
|
||
/** | ||
* Option for constructing a UpdateScope | ||
*/ | ||
export interface UpdateScopeOptions { | ||
/** | ||
* A workflow-unique identifier for this update. | ||
*/ | ||
id: string; | ||
|
||
/** | ||
* The update type name. | ||
*/ | ||
name: string; | ||
} | ||
|
||
// AsyncLocalStorage is injected via vm module into global scope. | ||
// In case Workflow code is imported in Node.js context, replace with an empty class. | ||
export const AsyncLocalStorage: new <T>() => ALS<T> = (globalThis as any).AsyncLocalStorage ?? class {}; | ||
|
||
export class UpdateScope { | ||
/** | ||
* A workflow-unique identifier for this update. | ||
*/ | ||
public readonly id: string; | ||
|
||
/** | ||
* The update type name. | ||
*/ | ||
public readonly name: string; | ||
|
||
constructor(options: UpdateScopeOptions) { | ||
this.id = options.id; | ||
this.name = options.name; | ||
} | ||
|
||
/** | ||
* Activate the scope as current and run the update handler `fn`. | ||
* | ||
* @return the result of `fn` | ||
*/ | ||
run<T>(fn: () => Promise<T>): Promise<T> { | ||
return storage.run(this, fn); | ||
} | ||
|
||
/** | ||
* Get the current "active" update scope. | ||
*/ | ||
static current(): UpdateScope | undefined { | ||
return storage.getStore(); | ||
} | ||
|
||
/** Alias to `new UpdateScope({ id, name }).run(fn)` */ | ||
static updateWithInfo<T>(id: string, name: string, fn: () => Promise<T>): Promise<T> { | ||
return new this({ id, name }).run(fn); | ||
} | ||
} | ||
|
||
const storage = new AsyncLocalStorage<UpdateScope>(); | ||
|
||
/** | ||
* Disable the async local storage for updates. | ||
*/ | ||
export function disableUpdateStorage(): void { | ||
storage.disable(); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.