Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions crates/common/src/payload_visitor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ pub struct DecodeVisitor<'a> {
impl AsyncPayloadVisitor for DecodeVisitor<'_> {
fn visit<'a>(&'a mut self, field: PayloadField<'a>) -> BoxFuture<'a, ()> {
Box::pin(async move {
if !should_encode(field.path) {
return;
}
match field.data {
PayloadFieldData::Single(payload) => {
let decoded = self
Expand Down Expand Up @@ -217,6 +220,8 @@ mod tests {
temporal::api::{
common::v1::{Memo, SearchAttributes},
failure::v1::failure::FailureInfo,
workflow::v1::WorkflowExecutionInfo,
workflowservice::v1::DescribeWorkflowExecutionResponse,
},
},
};
Expand Down Expand Up @@ -607,6 +612,54 @@ mod tests {
);
}

#[tokio::test]
async fn test_search_attributes_skipped_on_decode() {
let mut response = DescribeWorkflowExecutionResponse {
workflow_execution_info: Some(WorkflowExecutionInfo {
memo: Some(Memo {
fields: {
let mut memo = HashMap::new();
memo.insert("tracked".to_string(), make_payload("memo-value"));
memo
},
}),
search_attributes: Some(SearchAttributes {
indexed_fields: {
let mut sa = HashMap::new();
sa.insert("CustomField".to_string(), make_payload("search-value"));
sa
},
}),
..Default::default()
}),
..Default::default()
};

decode_payloads(
&mut response,
&MarkingCodec,
&SerializationContextData::Workflow,
)
.await;

let info = response.workflow_execution_info.as_ref().unwrap();
assert!(
is_decoded(info.memo.as_ref().unwrap().fields.get("tracked").unwrap()),
"memo should be decoded"
);
assert!(
!is_decoded(
info.search_attributes
.as_ref()
.unwrap()
.indexed_fields
.get("CustomField")
.unwrap()
),
"search attributes should NOT be decoded"
);
}

#[tokio::test]
async fn test_encode_single_payload() {
let mut payload = make_payload("test-data");
Expand Down
Loading