Skip to content

🔖 Prefix enum variants with type name#1319

Merged
jmaeagle99 merged 3 commits into
temporalio:mainfrom
jmaeagle99:ja/c-bridge-enum-prefix
Jun 9, 2026
Merged

🔖 Prefix enum variants with type name#1319
jmaeagle99 merged 3 commits into
temporalio:mainfrom
jmaeagle99:ja/c-bridge-enum-prefix

Conversation

@jmaeagle99

Copy link
Copy Markdown
Contributor

What was changed

Generate C bridge enum variants with type name prefix

Why?

Avoid collisions when enums have the same variant name.

Checklist

  1. Closes Prefix C bridge enums with type names #1318

@jmaeagle99
jmaeagle99 requested a review from a team as a code owner June 6, 2026 02:19

@Sushisource Sushisource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The WASM workflow failure I think might actually be related to this though? That one doesn't flake, whereas the other fails look like standard slow CI nonsense

@jmaeagle99

Copy link
Copy Markdown
Contributor Author

Thanks! The WASM workflow failure I think might actually be related to this though? That one doesn't flake, whereas the other fails look like standard slow CI nonsense

I think it's unrelated because the WASM tests have no dependency on the sdk-core-c-bridge crate and (while not exactly the same test) there are flakes in that suite on the main branch.

@Sushisource

Copy link
Copy Markdown
Member

Thanks! The WASM workflow failure I think might actually be related to this though? That one doesn't flake, whereas the other fails look like standard slow CI nonsense

I think it's unrelated because the WASM tests have no dependency on the sdk-core-c-bridge crate and (while not exactly the same test) there are flakes in that suite on the main branch.

Ah, ok. Weird. I'll have to figure that out.

@jmaeagle99
jmaeagle99 enabled auto-merge (squash) June 8, 2026 19:19
@jmaeagle99
jmaeagle99 merged commit 6bd00e8 into temporalio:main Jun 9, 2026
22 of 23 checks passed
@jmaeagle99
jmaeagle99 deleted the ja/c-bridge-enum-prefix branch June 9, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefix C bridge enums with type names

2 participants