You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The WASM workflow failure I think might actually be related to this though? That one doesn't flake, whereas the other fails look like standard slow CI nonsense
Thanks! The WASM workflow failure I think might actually be related to this though? That one doesn't flake, whereas the other fails look like standard slow CI nonsense
I think it's unrelated because the WASM tests have no dependency on the sdk-core-c-bridge crate and (while not exactly the same test) there are flakes in that suite on the main branch.
Thanks! The WASM workflow failure I think might actually be related to this though? That one doesn't flake, whereas the other fails look like standard slow CI nonsense
I think it's unrelated because the WASM tests have no dependency on the sdk-core-c-bridge crate and (while not exactly the same test) there are flakes in that suite on the main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Generate C bridge enum variants with type name prefix
Why?
Avoid collisions when enums have the same variant name.
Checklist