Add grpc-status trailers to fake gRPC responses#1257
Merged
Merged
Conversation
chris-olszewski
approved these changes
May 12, 2026
yuandrew
added a commit
to yuandrew/sdk-rust
that referenced
this pull request
May 13, 2026
yuandrew
added a commit
to yuandrew/sdk-rust
that referenced
this pull request
May 14, 2026
yuandrew
added a commit
to yuandrew/sdk-rust
that referenced
this pull request
May 14, 2026
yuandrew
added a commit
that referenced
this pull request
May 14, 2026
This was referenced May 15, 2026
Closed
yuandrew
added a commit
that referenced
this pull request
May 15, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
updated the two fake-success response builders to stream a final trailer frame containing
grpc-status: 0Why?
tonic version bumped, grpc/grpc-rust#2543
Our fake gRPC success responses are malformed, they send HTTP 200 plus a framed protobuf body, but they do not send the required final grpc-status: 0 trailer. Newer tonic correctly treats that as an invalid/truncated gRPC response, so tests fail with missing grpc-status trailer.
Checklist
Closes
How was this tested:
Note
Low Risk
Low risk: changes only how synthetic success responses are constructed by adding a standard gRPC trailer, with minimal impact beyond test/fake transports.
Overview
Updates the callback-based gRPC service and integration-test fake server helpers to stream a final trailers frame containing
grpc-status: 0after successful response data.This replaces previous “data-only” success bodies with
StreamBody/Frame-based bodies so responses are well-formed under newertonicvalidation.Reviewed by Cursor Bugbot for commit 99cd542. Bugbot is set up for automated code reviews on this repo. Configure here.