Skip to content

Add grpc-status trailers to fake gRPC responses#1257

Merged
yuandrew merged 1 commit into
temporalio:mainfrom
yuandrew:fix-fake-grpc-trailers
May 12, 2026
Merged

Add grpc-status trailers to fake gRPC responses#1257
yuandrew merged 1 commit into
temporalio:mainfrom
yuandrew:fix-fake-grpc-trailers

Conversation

@yuandrew

@yuandrew yuandrew commented May 12, 2026

Copy link
Copy Markdown
Contributor

What was changed

updated the two fake-success response builders to stream a final trailer frame containing grpc-status: 0

Why?

tonic version bumped, grpc/grpc-rust#2543

Our fake gRPC success responses are malformed, they send HTTP 200 plus a framed protobuf body, but they do not send the required final grpc-status: 0 trailer. Newer tonic correctly treats that as an invalid/truncated gRPC response, so tests fail with missing grpc-status trailer.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Note

Low Risk
Low risk: changes only how synthetic success responses are constructed by adding a standard gRPC trailer, with minimal impact beyond test/fake transports.

Overview
Updates the callback-based gRPC service and integration-test fake server helpers to stream a final trailers frame containing grpc-status: 0 after successful response data.

This replaces previous “data-only” success bodies with StreamBody/Frame-based bodies so responses are well-formed under newer tonic validation.

Reviewed by Cursor Bugbot for commit 99cd542. Bugbot is set up for automated code reviews on this repo. Configure here.

@yuandrew yuandrew requested a review from a team as a code owner May 12, 2026 16:40
@yuandrew yuandrew changed the title Fix fake gRPC success trailers Add grpc-status trailers to fake gRPC responses May 12, 2026
@yuandrew yuandrew merged commit c57f825 into temporalio:main May 12, 2026
102 of 107 checks passed
@yuandrew yuandrew deleted the fix-fake-grpc-trailers branch May 12, 2026 21:18
yuandrew added a commit to yuandrew/sdk-rust that referenced this pull request May 13, 2026
yuandrew added a commit to yuandrew/sdk-rust that referenced this pull request May 14, 2026
yuandrew added a commit to yuandrew/sdk-rust that referenced this pull request May 14, 2026
yuandrew added a commit that referenced this pull request May 14, 2026
* Shutdown rpc initiate shutdown (#1224)

* Use ActivityOptions struct literal

* Add grpc-status trailers to fake gRPC responses (#1257)

---------

Co-authored-by: Spencer Judge <spencer@temporal.io>
yuandrew added a commit that referenced this pull request May 15, 2026
* Shutdown rpc initiate shutdown (#1224)

* Use ActivityOptions struct literal, formatting

* Add grpc-status trailers to fake gRPC responses (#1257)

---------

Co-authored-by: Spencer Judge <spencer@temporal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants