💥 Record task latency even for WFT failures that were dropped#1207
Merged
Conversation
chris-olszewski
approved these changes
Apr 8, 2026
Comment on lines
+1734
to
+1737
| let body = get_text(format!("http://{addr}/metrics")).await; | ||
| let latency_line = body | ||
| .lines() | ||
| .find(|l| l.starts_with("temporal_workflow_task_execution_latency_count{")); |
Member
There was a problem hiding this comment.
Maybe wrap in an eventually in case it takes a bit for metrics to populate
Sushisource
force-pushed
the
normalize-metric
branch
from
April 9, 2026 16:59
aa6343d to
f45d3f9
Compare
Sushisource
enabled auto-merge (squash)
April 9, 2026 16:59
This was referenced May 1, 2026
Closed
This was referenced May 15, 2026
Closed
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
See title. This brings Core's reporting on this metric in-line with Go and Java. This is technically a breaking change as the metric is now recorded in more situations than it was previously, but we've decided that's worth it given the minor nature of the change and the benefit of consistency.
Why?
Consistency
Checklist
Closes [Bug] Worker Heartbeat: wf_task_latency doesn't always match 1:1 with total_processed_tasks #1202
How was this tested:
Added UT
Any docs updates needed?