💥 BREAKING CHANGE - Lazy passthrough for sys.modules and OpenAI converter/sandbox improvements #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
__contains__and__getitem__accesses to in-sandboxsys.modulesfor modules that are not there, but they are in outside-sandboxsys.modulesand are configured pass through, are lazily added to in-sandboxsys.modulesand returnedsys.modulesinside of sandboxsys.modulesto affect how they evaluate type hints without importingsys.modulebehavior inside of sandbox, so we have provided adisable_lazy_sys_module_passthroughoption in sandbox restriction config to opt-out if it breaks user workflowsopenai-agentsto>0.1sys.modulesissue being solved alongside an upstream resolution in OpenAI agents means that native Pydantic data converter can be usedagentsandopenaimodules (and their children) as passthrough for the entire SDKChecklist