Adding named params to openai activity configurations #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jun 23, 2025
cretz
approved these changes
Jun 23, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
LGTM since this is all experimental and will be moot if we have a plugin approach anyways
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
* Adding named params to openai activity configurations * Remove a few unused imports * Move model parameters into an object, remove activity id * Refer argument docs to , early check timeout * Removing example usage because of pydoctor errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Use named parameters instead of kwargs
Why?
Better documentation and ease of use
Checklist
Closes Add named parameters to OpenAI APIs #911
How was this tested:
Existing openai tests
Any docs updates needed?